Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to remove the FreeSurfer dependencies in the seg_only path (except for longitudinal, where we still have them), we replace
mri_coreg(andmri_vol2vol) calls withneuroreg coreg. This however changes a few things:mri_robust_registeris dropped as an option. It was basically another implementation of NMI using Powell optimiser and therefore a duplicate.In the future cubic interpolation will be added to
neuroregand then can be used here. If input precision is important beyond what float32 can do, let me know and that can be changed more easily.Finally, we will generate quick surfaces based on the registration and then can explore if
neuroreg bbregadds any value here.